THINK FIRST·CODE LATER

← All labs

Review an AI-generated pull request

Problem

Omar's pull request "Search posts by author" was generated with an AI assistant. The description says: "Adds search by author name. All tests pass ✅."

public class PostSearch {
    private Connection conn;

    public List<Post> byAuthor(String name) {
        List<Post> result = new ArrayList<>();
        try {
            Statement st = conn.createStatement();
            ResultSet rs = st.executeQuery(
                "SELECT * FROM posts WHERE author_name = '" + name + "' AND hidden = 0");
            while (rs.next()) {
                Post p = new Post(rs.getInt("id"), rs.getString("title"), rs.getString("author_name"),
                                  rs.getString("author_email"), rs.getBoolean("anonymous"));
                result.add(p);
                if (result.size() > 50) break;          // limit results
            }
        } catch (Exception e) {
        }
        System.out.println("search for " + name + " by " + currentUserEmail() + " found " + result.size());
        return result;
    }
}

@Test
public void testByAuthor() {
    List<Post> r = search.byAuthor("Yuki");
    assertEquals(r.size(), search.byAuthor("Yuki").size());
}

Write the review: at least eight specific comments (quote the line, explain the problem, propose the fix). Cover correctness, security, privacy, error handling, resource handling, the requirement, and the test. Then give your overall decision (approve / request changes) in one sentence.

Work it out on paper, in a document or here, then compare with the model answer. Your answer stays in your browser — it is never sent to or stored on the server.